Refactored shmbridge test #197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored shmbridge test to validate the upstream qcm drivers and check the driver initialisation Signed-off-by: Vamsee Narapareddi <[email protected]>
vnarapar
force-pushed
the
shmbridge_change
branch
from
9256a1e to
f37959f
Compare
smuppand
requested changes
Oct 16, 2025
|
|
||
| log_info "Checking kernel config for QCOM_SCM support..." | ||
| if ! check_kernel_config "CONFIG_QCOM_SCM"; then | ||
| log_fail "$TESTNAME : CONFIG_QCOM_SCM not enabled, test failed" |
There was a problem hiding this comment.
If the config is not enabled, can't we skip it instead of failing?
There was a problem hiding this comment.
As per tech team this is a mandatory config enforced to be enabled by upstream community
There was a problem hiding this comment.
In both cases, the log_* information is available because the necessary configuration is not enabled.
| echo "$TESTNAME PASS" > "$res_file" | ||
| log_info "Scanning dmesg logs for qcom_scm initialization" | ||
|
|
||
| if dmesg | grep -q 'qcom_scm'; then |
There was a problem hiding this comment.
Use https://github.com/qualcomm-linux/qcom-linux-testkit/blob/main/Runner/utils/functestlib.sh#L2800 to scan for the dmesg errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored shmbridge test to validate the upstream qcm drivers and check the driver initialisation